Re: Restrict publishing of partitioned table with a foreign table as partition

From: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
Date: 2025-04-01 14:48:21
Message-ID: CANhcyEXVPUAir9G1G1gT9k-xAMzhiV7GRX_fr1rkRhURNKDbxg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 28 Mar 2025 at 16:35, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2025-Mar-28, Shlok Kyal wrote:
>
> > On Mon, 24 Mar 2025 at 21:17, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> > > Also, surely we should document this restriction in the SGML docs
> > > somewhere.
> >
> > I have added comment in create_publication.sgml
>
> Hmm, okay, but "We cannot" is not the style used in the documentation.
> In addition, I think this mechanism should be mentioned in
> logical-replication.sgml; currently there's a note in the Restrictions
> section about foreign tables, which should be expanded to explain this.
>

I have modified the comment in create_publication.sgml and also added
comment in the restrictions section of logical-replication.sgml.
I have also added a more detailed explanation in comment of
'check_foreign_tables'

I have attached the updated v11 patch.

Thanks and Regards,
Shlok Kyal

Attachment Content-Type Size
v11-0001-Restrict-publishing-of-partitioned-table-with-fo.patch application/octet-stream 30.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-04-01 15:08:34 Re: AIO writes vs hint bits vs checksums
Previous Message David G. Johnston 2025-04-01 14:40:44 Re: add function argument name to substring and substr