Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY

On Thu, 28 Nov 2024 at 16:38, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Nov 21, 2024 at 5:30 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
>
> Review comments:
> ===============
> 1.
> +
> + /*
> + * true if all generated columns which are part of replica identity are
> + * published or the publication actions do not include UPDATE or DELETE.
> + */
> + bool replident_valid_for_update;
> + bool replident_valid_for_delete;
>
> These are too generic names for the purpose they are used. How about
> instead name them as gencols_valid_for_update and
> gencols_valid_for_delete?
>
> 2. The comments atop RelationBuildPublicationDesc() is only about row
> filter. We should update it for column list and generated columns as
> well.
>
> 3. It is better to merge the functionality of the invalid column list
> and unpublished generated columns as proposed by Hou-San above.
>

Thanks for reviewing the patch. I have addressed the comments and
updated the patch.

Thanks and Regards,
Shlok Kyal