Re: ]GTK 3

From: Björn Harrtell <bjorn(dot)harrtell(at)gmail(dot)com>
To: Björn Harrtell <bjorn(at)wololo(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: ]GTK 3
Date: 2016-01-05 22:54:07
Message-ID: CANhDX=bE9Wx6D2jNzDcFrMGvMiRTHfW9Svup6SAxzV2Pb=BdvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Found the theme color issue.

Server node color is customizable and new server nodes are created with
background from window and saved in .pgadmin3.

I don't see the usefulness of this feature so I've attached patch that
removes it.

I see there is alot of work to be done to modernize the usage of wxWidgets
to take advantage of new widgets for trees, lists and toolbar and perhaps
even the grid. Any interest in contributions towards this?

/Björn

PS. Dug alot into the code base to finally discover the above and noticed
there is *alot* of work to do to properly go to wxWidgets 3.0+.

2015-12-18 14:35 GMT+01:00 Björn Harrtell <bjorn(dot)harrtell(at)gmail(dot)com>:

> Thanks,
>
> I'm on Debian testing and have just managed to compile wxWindows 3.0.2
> against GTK 3.18, then pgadmin3 against that.
>
> I'm surprised to report that it compiles and runs fine! I'm impressed by
> the API compatibility of wxWindows.
>
> However, my initial reason for exploring this was that the standard
> pgadmin3 compiled against GTK 2 wasn't themed to my GNOME 3 desktop which I
> thought would be resolved by using GTK 3 but it does not. Some elements
> works as expected, like for instance the GTK 3 file browser is opened, but
> other issues remain. The most glaring example is that the browser tree
> items have a white background regardless of theme (applies to both GTK 2
> and 3), and will be unreadable if using dark themes (that have light
> colored text).
>
> /Björn
>
> 2015-12-18 14:04 GMT+01:00 Timon <timosha(at)gmail(dot)com>:
>
>> I've tried to build under fedora 23
>>
>> ./configure CXXFLAGS="-W./configure --with-wx-version=3.0
>> CXXFLAGS="-Wno-deprecated-declarations -Wl,-z,lazy -fPIC -pie"
>> CFLAGS="-fPIC -pie"
>> make -j 10
>>
>> but it failed on linking stage with errors like
>>
>> pgAdmin3.o: In function `wxCreateApp()':
>> pgAdmin3.cpp:(.text+0x16): undefined reference to
>> `wxAppConsole::CheckBuildOptions(char const*, char const*)'
>> pgAdmin3.o: In function `frmDlgTest::frmDlgTest()':
>> pgAdmin3.cpp:(.text+0x381): undefined reference to `wxDir::~wxDir()'
>> pgAdmin3.cpp:(.text+0x423): undefined reference to `wxDir::~wxDir()'
>> pgAdmin3.o: In function `pgAdmin3::OnInit()':
>> .....
>>
>> 2015-12-18 14:35 GMT+03:00 Björn Harrtell <bjorn(dot)harrtell(at)gmail(dot)com>:
>>
>>> Hi devs,
>>>
>>> Have anyone investigated compiling pgadmin using wxWidgets > 2.9.4 and
>>> GTK+ 3 which can be enabled with configure option --with-gtk=3?
>>>
>>> I'm putting an effort into it now and will share results here, but will
>>> appreciate information from anyone with existing experience.
>>>
>>> /Björn
>>>
>>
>>
>>
>> --
>> All bugs reserved
>>
>
>

Attachment Content-Type Size
fc2747d2201cb13ba89df1e509186f6e6e1fb297.diff text/plain 58.1 KB

In response to

  • Re: ]GTK 3 at 2015-12-18 13:35:22 from Björn Harrtell

Responses

  • Re: ]GTK 3 at 2016-01-06 08:54:27 from Guillaume Lelarge

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2016-01-06 05:54:30 Re: Compiling on El Capitan with Home Brew?
Previous Message Ashesh Vashi 2016-01-05 20:55:25 pgAdmin 4 commit: Making minor changes: