Re: ]GTK 3

Yes, sorry, I made both the comments and the patch too hastily and agree
that it should not be removed based on my findings.

It should be noted though that wx3 or GTK3 by themselves is not to blame
here, I'm guessing it should affect wx2 and GTK2 too because it's more of a
logical problem in where a user created the server node in a light theme
which will save a white color for the background... then if the user
switches to a dark theme, the saved white color is problematic.

I noticed work on pgadmin4 too and while interesting, I want to see
pgadmin3 shine on linux desktops in the life it has left which might be
quite some time (?). I see several distinct areas of work that I'd like to
contribute efforts with:

1. Upgrade to latest stable wx
2. Compile with GTK+ 3.x as default on Linux (not sure it's ready for this,
needs research and collaboration with dist packaging)
3. Evaluate which controls that can/need replacement (i.e replace with
wxTreeListCtrl, wxDataViewCtrl and perhaps wxToolBar)
4. Refactor existing code to use the controls that pass evaulation

Feedback and guidance on how to proceed is much appreciated!

/Björn

2016-01-06 10:48 GMT+01:00 Dave Page <dpage(at)pgadmin(dot)org>:

> On Wed, Jan 6, 2016 at 8:54 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > 2016-01-05 23:54 GMT+01:00 Björn Harrtell <bjorn(dot)harrtell(at)gmail(dot)com>:
> >>
> >> Found the theme color issue.
> >>
> >> Server node color is customizable and new server nodes are created with
> >> background from window and saved in .pgadmin3.
> >>
> >> I don't see the usefulness of this feature so I've attached patch that
> >> removes it.
> >>
> >
> > -1
> >
> > I didn't see either when it was commited, but I know many users who are
> > really fond of the feature. It helps them track which kind of servers
> > they're connected to (production, testing, dev, etc).
>
> Right - we're not removing functionality because it doesn't work
> properly (yet) in wx3. FYI, I wrote and committed that feature at
> PGCon one year.
>
> >> I see there is alot of work to be done to modernize the usage of
> wxWidgets
> >> to take advantage of new widgets for trees, lists and toolbar and
> perhaps
> >> even the grid. Any interest in contributions towards this?
> >>
> >
> > I would say yes, but be aware that the next major release of pgAdmin (as
> in
> > pgAdmin IV) won't use wxwidgets.
>
> Correct.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>