Error for WITH options on partitioned tables

From: Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Error for WITH options on partitioned tables
Date: 2022-09-16 12:13:51
Message-ID: CANbhV-H=eZ9kTR9mUgKGK0Qv9uXP=U+dQg3rinQHfTdFMhBA2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Someone on general list recently complained that the error message
from trying to use options on a partitioned table was misleading,
which it definitely is:

CREATE TABLE parted_col_comment (a int, b text) PARTITION BY LIST (a)
WITH (fillfactor=100);
ERROR: unrecognized parameter "fillfactor"

Which is verified by patch 001.

Patch 002 replaces this with a more meaningful error message, which
matches our fine manual.
https://www.postgresql.org/docs/current/sql-createtable.html

ERROR: cannot specify storage options for a partitioned table
HINT: specify storage options on leaf partitions instead

--
Simon Riggs http://www.EnterpriseDB.com/

Attachment Content-Type Size
001_test_options_with_partitioned_table.v1.patch application/octet-stream 1.3 KB
002_better_error_for_options_on_partitioned.v1.patch application/octet-stream 1.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2022-09-16 12:20:20 Re: SUBTRANS: Minimizing calls to SubTransSetParent()
Previous Message Bharath Rupireddy 2022-09-16 11:28:29 Re: Switching XLog source from archive to streaming when primary available