| From: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Damage control for planner's get_actual_variable_endpoint() runaway |
| Date: | 2022-11-21 18:44:17 |
| Message-ID: | CANbhV-GUAo5cOw6XiqBjsLVBQsg+=kpcCCWYjdTyWzLP28ZX-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 21 Nov 2022 at 18:17, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On November 21, 2022 9:37:34 AM PST, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> This can't quite be right - isn't this only applying the limit if we found a
> >> visible tuple?
> >
> >It doesn't look that way to me, but perhaps I'm just too dense to see
> >the problem?
>
> The earlier version didn't have the issue, but the latest seems to only limit after a visible tuple has been found. Note the continue; when fetching a heap tuple fails.
Agreed, resolved in this version.
Robert, something like this perhaps? limit on both the index and the heap.
--
Simon Riggs http://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Damage-control-for-planner-s-get_actual_variable_end.v2.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | sirisha chamarthi | 2022-11-21 18:48:55 | Re: Catalog_xmin is not advanced when a logical slot is lost |
| Previous Message | sirisha chamarthi | 2022-11-21 18:40:08 | Re: Catalog_xmin is not advanced when a logical slot is lost |