| From: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
|---|---|
| To: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
| Cc: | David Zhang <david(dot)zhang(at)highgo(dot)ca>, Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Error for WITH options on partitioned tables |
| Date: | 2022-11-07 11:10:06 |
| Message-ID: | CANbhV-EmEV0YxFJ7=o3fm0qGTTiysz9tod1OPR72QzMHDSxR+g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 7 Nov 2022 at 08:55, Karina Litskevich
<litskevichkarina(at)gmail(dot)com> wrote:
>
> Hi David,
>
> > I am not very clear about why `build_reloptions` is removed in patch
> > `v2-0002-better-error-message-for-setting-parameters-for-p.patch`, if
> > you can help explain would be great.
>
> "build_reloptions" parses "reloptions" and takes for it a list of allowed
> options defined by the 5th argument "relopt_elems" and the 6th argument
> "num_relopt_elems", which are NULL and 0 in the removed call. If "validate"
> is false, it ignores options, which are not in the list, while parsing. If
> "validate" is true, it "elog"s ERROR when it meets option, which is not in the
> allowed list.
Karina's changes make sense to me, so +1.
This is a minor patch, so I will set this as Ready For Committer.
--
Simon Riggs http://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-11-07 11:23:35 | Re: thinko in basic_archive.c |
| Previous Message | Simon Riggs | 2022-11-07 10:58:05 | Re: New docs chapter on Transaction Management and related changes |