| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: clang-tidy complaints |
| Date: | 2025-04-26 20:19:29 |
| Message-ID: | CANWCAZb0_qSt_e0aq24nCf0O6-+q3byobTY3_wazWwYraHQwQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Apr 12, 2025 at 11:25 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> I just pushed my annual commit that makes function parameter names
> consistent between function declarations and their corresponding
> definitions, to cover the Postgres 18 cycle.
The new CRC function this touched was right in the header but the
parameter in the definition didn't match match surrounding code (my
fault in 3c6e8c123), so I went ahead and fixed up the definition. (As
an aside, one wrinkle in the clang-tidy result is that it only touched
the declaration in the "runtime check" stanza and not the "targeting
SSE 4.2" stanza.)
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-04-26 21:07:46 | Re: pgsql: Add function to get memory context stats for processes |
| Previous Message | John Naylor | 2025-04-26 20:08:31 | pgsql: Match parameter in new function to earlier equivalents |