| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Comment cleanup - it's vs its |
| Date: | 2025-01-29 07:15:02 |
| Message-ID: | CANWCAZat7maVMV-+eNFQJJ3aB1D2OWQ6cYaHp7XMg+OEGz=jgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 29, 2025 at 1:46 PM Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com> wrote:
>
> I noticed a few incorrect usages of it's vs its and decided to search systematically for any mistakes. Overall, we use it right more than 99% of the time but there were still about 20 mistakes.
LGTM, except maybe this one:
- * try read non-locale sign, it's happen only if format is not exact
+ * try read non-locale sign, it happens only if format is not exact
...sounds better to me with "which happens".
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kashif Zeeshan | 2025-01-29 07:23:28 | Re: EDB Installer initcluster script changes - review requested |
| Previous Message | vignesh C | 2025-01-29 07:14:26 | Re: Introduce XID age and inactive timeout based replication slot invalidation |