| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Davin Shearer <davin(at)apache(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: micro-optimizing json.c |
| Date: | 2023-12-08 04:51:15 |
| Message-ID: | CANWCAZapSoHibA2fPZhfaDbN_vEsc8G_MH=fzpTs5TMixSPoyA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 8, 2023 at 10:32 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Fri, Dec 08, 2023 at 04:11:52PM +1300, David Rowley wrote:
> > + seplen = use_line_feeds ? sizeof(",\n ") - 1 : sizeof(",") - 1;
> >
> > Most modern compilers will be fine with just:
> >
> > seplen = strlen(sep);
> >
> > I had to go back to clang 3.4.1 and GCC 4.1.2 to see the strlen() call
> > with that code [1].
>
> Hm. I tried this first, but my compiler (gcc 9.4.0 on this machine) was
> still doing the strlen()...
This is less verbose and still compiles with constants:
use_line_feeds ? strlen(",\n ") : strlen(",");
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2023-12-08 05:02:08 | Re: Memory consumed by paths during partitionwise join planning |
| Previous Message | Michael Paquier | 2023-12-08 04:45:18 | Re: Is WAL_DEBUG related code still relevant today? |