Re: Change GUC hashtable to use simplehash?

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Ants Aasma <ants(dot)aasma(at)cybertec(dot)at>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Change GUC hashtable to use simplehash?
Date: 2025-01-29 07:02:59
Message-ID: CANWCAZai=YQNV_VY6tt=pL2RquU2NNr2WQbuj3G8hYeJBeGyyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 23, 2025 at 8:52 AM Anton A. Melnikov
<a(dot)melnikov(at)postgrespro(dot)ru> wrote:
>
> Hi!
>
> On 22.01.2025 11:37, John Naylor wrote:
> > On Fri, Jan 17, 2025 at 4:50 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> >>
> >> It would be a lot more readable to revert the offending commit
> >> instead, since its predecessor had a much simpler bytewise loop.
>
> Agreed that reverting seems as a preferable way, and here's why.

This is done -- thanks for the report, and for testing.

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-01-29 07:14:26 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message Peter Smith 2025-01-29 07:01:04 Re: Introduce XID age and inactive timeout based replication slot invalidation