| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com> |
| Subject: | Re: Improve CRC32C performance on SSE4.2 |
| Date: | 2025-04-06 08:11:38 |
| Message-ID: | CANWCAZa_iAhjd-6TVY5NfDzyoSJxFgsMrPW0YwKuTMF7a75D9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 5, 2025 at 5:15 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> I noticed that autoconf is defining USE_AVX512_CRC_WITH_RUNTIME_CHECK, but
> everywhere else expects USE_AVX512_CRC32C_WITH_RUNTIME_CHECK (with the
> "32C" included). I tested the v16 patches (with the macro fixed and
> assertions enabled) on a machine with AVX-512 (verified with some extra
> debug logging), and everything passed.
Yikes, I even made a mental note to verify the relevant object file
still had the same contents as v14, and I clearly didn't do that on
the autoconf side. Thanks for running the smoke test! I fixed that,
made a couple more tiny comment changes and pushed.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-04-06 11:23:24 | Re: Removing unneeded self joins |
| Previous Message | Michael Paquier | 2025-04-06 06:53:14 | Re: Back-patch of: avoid multiple hard links to same WAL file after a crash |