Re: pgsql: Inline CRC computation for small fixed-length input on x86

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org, cookt(at)blackduck(dot)com
Subject: Re: pgsql: Inline CRC computation for small fixed-length input on x86
Date: 2025-04-01 04:20:43
Message-ID: CANWCAZa7qLYyPAeNvkRJnGgAbsMWZzkzCyd318YoRabqps9TDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Mar 31, 2025 at 8:09 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
> > What I conclude is that Red Hat hot-wired gcc to assume -msse4.2,
> > but they didn't hot-wire clang the same way.
>
> In confirmation of that: everything goes through fine if I manually
> add -msse4.2 to configure's choice of BITCODE_CFLAGS. Not sure if
> that line of thought can lead to a usable solution, or if it's
> superior to messing with the attributes on relevant functions as
> you mooted upthread.

Thanks for doing additional legwork!

Since the broader issue is still up in the air, and we have
confirmation that the attributes will get the buildfarm green again,
I'll go do that now.

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2025-04-01 05:06:59 pgsql: Use function attributes for SSE 4.2 even when targeting that ext
Previous Message Tatsuo Ishii 2025-04-01 00:48:24 Re: pgsql: Add memory/disk usage for Window aggregate nodes in EXPLAIN.