Re: Tidy fill hstv array (src/backend/access/heap/pruneheap.c)

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tidy fill hstv array (src/backend/access/heap/pruneheap.c)
Date: 2024-01-14 13:55:28
Message-ID: CANWCAZZpz2-QoPc9iKaD6CO-UNXMdtYxT4noUFk_d+rgDG4OTQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 13, 2024 at 9:36 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Em ter., 9 de jan. de 2024 às 06:31, John Naylor <johncnaylorls(at)gmail(dot)com> escreveu:

>> This just moves an operation from one place to the other, while
>> obliterating the explanatory comment, so I don't see an advantage.
>
> Well, I think that is precisely the case for using memset.
> The way initialization is currently done is much slower and harmful to the branch.
> Of course, the gain should be small, but it is fully justified for switching to memset.

We haven't seen any evidence or reasoning for that. Simple
rules-of-thumb are not enough.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-01-14 14:02:33 Re: plperl and perl 5.38
Previous Message John Naylor 2024-01-14 13:42:49 Re: [PoC] Improve dead tuple storage for lazy vacuum