Re: Comment cleanup - it's vs its

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Comment cleanup - it's vs its
Date: 2025-01-29 07:50:27
Message-ID: CANWCAZYUQi2tKpVRzFBL5K0SMOEG3J5-n_YghEY+V3txhwRQQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 29, 2025 at 2:26 PM Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com> wrote:
>
> > I just noticed this, too:
> >
> > -# DROP DATABASE should drops it's slots, including active slots.
> > +# DROP DATABASE should drops its slots, including active slots.
> >
> > "should drop"
>
> Ah, good catch. Fixed in v3.

(Note: You forgot reply-all for your later messages). I ran pgindent
after applying and found it re-indented an entire paragraph. That
seemed like an unfortunate side-effect for a typo fix, so I took the
liberty of adding an additional space after a period. Some comments
use the two-space style anyway. Pushed, thanks for the patch!

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-01-29 08:37:07 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message jian he 2025-01-29 07:50:09 Re: Extended Statistics set/restore/clear functions.