Re: pgsql: Inline CRC computation for small fixed-length input on x86

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Todd Cook <cookt(at)blackduck(dot)com>
Cc: John Naylor <john(dot)naylor(at)postgresql(dot)org>, "pgsql-committers(at)lists(dot)postgresql(dot)org" <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Inline CRC computation for small fixed-length input on x86
Date: 2025-04-01 06:48:07
Message-ID: CANWCAZYN=UcHdcyCMeh+Xd=eDDVdRfwk_XmQnoGC0sfzfcHQ6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 1, 2025 at 1:58 AM Todd Cook <cookt(at)blackduck(dot)com> wrote:
>
> On 3/31/25, 7:17 AM, "John Naylor" <johncnaylorls(at)gmail(dot)com <mailto:johncnaylorls(at)gmail(dot)com>> wrote:
> > A possible workaround would be add a normally-superfluous
> > "pg_attribute_target("sse4.2")" to the inlined function, as in the
> > attached.
>
> The build succeeds on skimmer with this patch and using the configure command from
> the build farm status page[1].

I see bumblebee is now green for the first time. Thanks for testing!

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2025-04-01 10:33:56 pgsql: heapam: Only set tuple's block once per page in pagemode
Previous Message John Naylor 2025-04-01 05:06:59 pgsql: Use function attributes for SSE 4.2 even when targeting that ext