From: | Usman Khan <umk555(at)gmail(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, Zaid Shabbir <zaidshabbir(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Disabled or Not applicable Tabs design |
Date: | 2025-02-22 11:18:19 |
Message-ID: | CANVC+RF45vaamZYnr=q0j-Q9-9Yo_Tug_1SsBAfvt87G-xLe_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Feb 21, 2025 at 4:47 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Fri, 21 Feb 2025 at 11:40, Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Zaid,
>>
>> Changing tab design will need changes in the complete application. It
>> also needs to be discussed with everyone before changing it.
>> Anyway, it should not be part of the task I'm working on. You can open a
>> separate thread for discussions.
>>
>
> Agreed.
>
> I do think the greyed option is the best way forward, even if there are
> potential improvements we could make to the design app-wide.
>
>
>>
>> On Fri, Feb 21, 2025 at 5:03 PM Zaid Shabbir <zaidshabbir(at)gmail(dot)com>
>> wrote:
>>
>>> Hello,
>>>
>>> Some other samples for the tabular window.
>>>
>>> [image: Screenshot 2025-02-21 at 4.29.30 PM.png]
>>>
>>> Aditiya it's just a suggestion, you can use the most suitable layout and
>>> colors.
>>>
>>> Regards,
>>> Zaid Shabbir
>>>
>>>
>>>
>>> On Fri, Feb 21, 2025 at 3:59 PM Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Zaid,
>>>>
>>>> On Fri, Feb 21, 2025 at 4:26 PM Zaid Shabbir <zaidshabbir(at)gmail(dot)com>
>>>> wrote:
>>>>
>>>>> Hello Aditya,
>>>>>
>>>>> The above design looks good to me. We could improve visibility by
>>>>> adding vertical and horizontal lines in a combination of blue, gray, and
>>>>> black. Blue represents the current active tab, gray indicates a disabled
>>>>> tab, and black signifies available clickable options.
>>>>>
>>>>> e.g.
>>>>>
>>>>> [image: Sample.png]
>>>>>
>>>> That doesn't match the pgAdmin design. The colors which you mentioned
>>>> are already being used.
>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>> Zaid Shabbir
>>>>>
>>>>> On Fri, Feb 21, 2025 at 3:32 PM Aditya Toshniwal <
>>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Updated design:
>>>>>>
>>>>>> [image: image.png]
>>>>>>
>>>>>> On Fri, Feb 21, 2025 at 3:56 PM Aditya Toshniwal <
>>>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> On Fri, Feb 21, 2025 at 3:21 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, 21 Feb 2025 at 09:38, Aditya Toshniwal <
>>>>>>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>> Hi Hackers,
>>>>>>>>>
>>>>>>>>> I've been working on a new feature to restore a plain SQL using
>>>>>>>>> the pgAdmin restore dialog. Internally, it will select pg_restore or psql
>>>>>>>>> based on the format.
>>>>>>>>>
>>>>>>>>> Now, when restoring plain format the tabs like Data Options,
>>>>>>>>> Query Options are not applicable. So instead of going and disabling all the
>>>>>>>>> fields under these tabs, I think we can simply disable the complete tab.
>>>>>>>>>
>>>>>>>>> I've come up with the following UI design for the disabled tabs.
>>>>>>>>> The tabs will enable/disable based on the format selected.
>>>>>>>>>
>>>>>>>>> Please share your feedback on this.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [image: image.png]
>>>>>>>>>
>>>>>>>>
>>>>>>>> Normally when something is disabled, it is simply greyed out and
>>>>>>>> made to not respond to input. Why not do the same here instead of designing
>>>>>>>> a new way of indicating disabled state?
>>>>>>>>
>>>>>>> I thought of adding an icon for better accessibility. Greying is
>>>>>>> pretty straightforward.
>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> pgEdge: https://www.pgedge.com
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Thanks,
>>>>>>> Aditya Toshniwal
>>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>>> <https://www.enterprisedb.com/>
>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/>
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/>
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
>> <https://www.enterprisedb.com/>
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> pgEdge: https://www.pgedge.com
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Usman Khan | 2025-02-22 11:20:30 | Re: Disabled or Not applicable Tabs design |
Previous Message | Dave Page | 2025-02-21 11:47:30 | Re: Disabled or Not applicable Tabs design |