From: | Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.) |
Date: | 2018-05-04 22:26:24 |
Message-ID: | CANPAkgusriFJT3Yc_qvQjLKTaicF-iiJhW9oLrghobkHOMTv1g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro,
I didn't mean to imply otherwise. Our settings here are probably
different.
Good point on the git log --grep. I'll try to remember that in the future.
Mike
__________________________________________________________________________________
*Mike Blackwell | Technical Analyst, Distribution Services/Rollout
Management | RRD*
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike(dot)Blackwell(at)rrd(dot)com
http://www.rrdonnelley.com
<http://www.rrdonnelley.com/>
* <Mike(dot)Blackwell(at)rrd(dot)com>*
On Fri, May 4, 2018 at 4:36 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> Moving discussion to -hackers list.
>
> Mike Blackwell wrote:
> > I didn't see a .perlcriticrc file in the project, so ran with our local
> > settings.
> >
> > With those, perlcritic is pretty unhappy, even at -4, though I don't see
> > anything that pops out as potentially bug-inducing.
>
> Uh, we've certainly fixed things to appease perlcritic before (see git
> log --grep perlcritic). Maybe we need to come up with some .rc file to
> our liking and try to adhere to it.
>
> --
> Álvaro Herrera https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2018-05-04 22:37:13 | pgsql: Fix scenario where streaming standby gets stuck at a continuatio |
Previous Message | Alvaro Herrera | 2018-05-04 21:36:05 | perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.) |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2018-05-04 22:49:31 | Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)? |
Previous Message | Tom Lane | 2018-05-04 22:21:31 | Re: --enable-ccache configure option |