Re: [PATCH] Incremental sort (was: PoC: Partial sort)

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: James Coleman <jtc331(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: 2019-06-24 18:05:24
Message-ID: CANP8+jLw+WQEUN5zZwQ_egr2WSbsR2bWqY79fS5BzAMJmLJCDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 24 Jun 2019 at 18:01, James Coleman <jtc331(at)gmail(dot)com> wrote:

> On Mon, Jun 24, 2019 at 12:56 PM Simon Riggs <simon(at)2ndquadrant(dot)com>
> wrote:
>
> > What is the specific use case for this? This sounds quite general case.
>
> They are both general cases in some sense, but the concerns lie mostly
> with what happens when they're unexpectedly encountered. For example,
> if the expected row count or group size is off by a good bit and we
> effectively have to perform a sort of all (or most) possible rows.
>
> If we can get the performance to a point where that misestimated row
> count or group size doesn't much matter, then ISTM including the patch
> becomes a much more obvious total win.
>

I was trying to think of ways of using external information/circumstance to
knowingly avoid negative use cases. i.e. don't treat sort as a black box,
use its context.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Solutions for the Enterprise

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-06-24 18:28:50 Re: Minimal logical decoding on standbys
Previous Message Andres Freund 2019-06-24 18:02:30 Re: Remove HeapTuple and Buffer dependency for predicate locking functions