| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ALTER INDEX .. SET STATISTICS ... behaviour |
| Date: | 2017-09-06 16:59:20 |
| Message-ID: | CANP8+jLmfWZ2qSZhbp2ADFK5226zgqPw0k4=njssFnczrNdwJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4 September 2017 at 10:30, Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com> wrote:
> On 09/04/2017 06:16 PM, Alexander Korotkov wrote:
>> Looks good for me. I've integrated those changes in the patch.
>> New revision is attached.
>
> Thanks, I changed status to "ready for commiter".
This looks useful and good to me.
I've changed this line of code to return NULL rather than return tuple
if (!HeapTupleIsValid(tuple))
return tuple;
Other than that, I'm good to commit.
Any last minute objections?
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-06 17:17:18 | Re: Fix performance of generic atomics |
| Previous Message | Robert Haas | 2017-09-06 16:43:42 | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |