From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, rafia(dot)sabih(at)enterprisedb(dot)com, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Compressed TOAST Slicing |
Date: | 2019-02-20 18:37:40 |
Message-ID: | CANP8+jLTxAG=BZCv3x9n8UpnS4A-EHMeARATgpA2xmE8yYL0aA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 20 Feb 2019 at 16:27, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > Sure, but we have the choice between something that benefits just a few
> > cases or one that benefits more widely.
> >
> > If we all only work on the narrow use cases that are right in front of us
> > at the present moment then we would not have come this far. I'm sure many
> > GIS applications also store JSONB data, so you would be helping the
> > performance of the whole app, even if there isn't much JSON in PostGIS.
>
> -1, I think this is blowing up the complexity of a already useful patch,
> even though there's no increase in complexity due to the patch proposed
> here. I totally get wanting incremental decompression for jsonb, but I
> don't see why Paul should be held hostage for that.
>
Not sure I agree with your emotive language. Review comments != holding
hostages.
If we add one set of code now and need to add another different one later,
we will have 2 sets of code that do similar things.
I'm surprised to hear you think that is a good thing.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Paul Ramsey | 2019-02-20 18:45:37 | Re: Compressed TOAST Slicing |
Previous Message | Simon Riggs | 2019-02-20 18:31:25 | Re: propagating replica identity to partitions |