From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
Subject: | Re: ALTER TABLE behind-the-scenes effects' CONTEXT |
Date: | 2016-01-05 06:45:47 |
Message-ID: | CANP8+jLDKqSm+PudDtz6bt4OsPSQVcRSWN=CjnRuKiXEqZA43Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 4 January 2016 at 20:44, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Maybe
> there are more ALTER TABLE subcommands that should be setting something
> up? In cases where multiple subcommands are being run, it might be
> useful to see which one caused a certain error message.
>
I like the patch.
We should have a message for each subcommand, since there are many that run
for a long time and we support the optimization of allowing many
subcommands together at once.
There should also be a comment about making name a requirement for any
subcommand.
> I think some additional tests wouldn't hurt.
>
Each subcommand message should be generated at least once in tests.
> I await feedback from Simon Riggs, who set himself up as reviewer a
> couple of days ago. Simon, do you also intend to be committer? If so,
> please mark yourself as such in the commitfest app.
>
Happy to be the committer on this.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Vitaly Burovoy | 2016-01-05 08:07:34 | Re: Extracting fields from 'infinity'::TIMESTAMP[TZ] |
Previous Message | Amit Langote | 2016-01-05 06:13:23 | Re: Accessing non catalog table in backend |