Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cleanup - Removed unused function parameter in reorder buffer & parallel vacuum
Date: 2020-07-03 08:36:27
Message-ID: CANP8+jL4h3gT1iYT0dMCr5HYtJBowvX10vV5Zm+B=fUoBWWXtw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 3 Jul 2020 at 09:07, vignesh C <vignesh21(at)gmail(dot)com> wrote:

> While checking through the code I found that some of the function
> parameters in reorderbuffer & vacuumlazy are not used. I felt this
> could be removed. I'm not sure if it is kept for future use or not.
> Attached patch contains the changes for the same.
> Thoughts?
>

Unused? To confirm that, everybody that has a logical decoding plugin needs
to check their code so we are certain this is sensible.

Seems like a change with low utility.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
Mission Critical Databases

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-07-03 08:59:36 Re: Missing "Up" navigation link between parts and doc root?
Previous Message Nikolay Shaplov 2020-07-03 08:31:08 Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions