Re: Unused(?) field Form_pg_sequence.sequence_name, not updated by seq rename

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unused(?) field Form_pg_sequence.sequence_name, not updated by seq rename
Date: 2015-12-15 07:17:15
Message-ID: CANP8+jL0YoR3=oUcVWAKyWw+uLNHaVr6xgiqFX7qEbtN74aU2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15 December 2015 at 04:40, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

> It gets written as part of the Form_pg_sequence each time we write a
> sequence advance to WAL, but just seems to be a waste of space.
>

Agreed

> Am I missing something obvious or should it just be removed? Or perhaps
> replaced with the sequence's Oid in pg_class, since that'd be quite handy
> for logical decoding of sequences.
>

If the name is wrong then probably other fields are wrong also when we do
ALTER SEQUENCE?

We should add the fields you need, but don't alter anything in
Form_pg_sequence.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2015-12-15 08:35:41 Check for interrupts in bf and xdes crypt()
Previous Message Michael Paquier 2015-12-15 07:13:57 Re: pgbench stats per script & other stuff