Re: [COMMITTERS] pgsql: Collect and use multi-column dependency stats

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Collect and use multi-column dependency stats
Date: 2017-04-06 12:47:50
Message-ID: CANP8+jKnpeiejq2LrtyAPZKB4H_6KUqRo5YTN6wgu5VWeScXAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 5 April 2017 at 18:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> Collect and use multi-column dependency stats
>
> The buildfarm is unhappy about the fact that this changed the API
> for clauselist_selectivity(). I am not convinced that that change
> was a good idea, so before telling FDW authors that they need to
> change their code, I'd like to hear a defense of the API change.
> Why not just use the existing varRelid parameter for that? Why
> is there an assumption that only one rel's extended stats will
> ever be of interest? This function does get used for join clauses.

Point noted. Reading thread and hope to fix today.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-04-06 13:11:35 Re: pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()
Previous Message Peter Eisentraut 2017-04-06 12:44:08 pgsql: Identity columns

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2017-04-06 13:11:23 Re: [GSoC] Push-based query executor discussion
Previous Message Stephen Frost 2017-04-06 12:47:40 Re: Re: new set of psql patches for loading (saving) data from (to) text, binary files