| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 2016-03 Commitfest |
| Date: | 2016-04-08 15:52:20 |
| Message-ID: | CANP8+jKe6nbOyx4fFkWuCaeh3-HejxyGsZX8m17cfjeW9n+4EQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8 April 2016 at 16:00, Andres Freund <andres(at)anarazel(dot)de> wrote:
I've finished polishing the Pin/Unpin patch. But the final polishing
> happened on an intercontential flight, after days spent preparing my
> move to SF. I'd be glad if you would allow me to look over the patch
> again, before pushing it sometime this weekend; this stuff is subtle,
> and I'm not exactly my best right now.
>
I think you should push it now then.
Two reasons
1) We shouldn't be violating the deadline the first time its been in place.
It just creates a precedent that sometimes the deadlines don't matter and
that's not a useful position.
2) If you commit what you have, someone else might be able to see a bug you
cannot
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-08 15:52:45 | Re: 2016-03 Commitfest |
| Previous Message | Robert Haas | 2016-04-08 15:45:59 | Re: [PATCH] speeding up GIN build with parallel workers |