Re: pg_dump broken for non-super user

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump broken for non-super user
Date: 2016-05-07 14:25:30
Message-ID: CANP8+jKBYXuJ=fpu-ZHUJ_KRg1UomQip=Uev-Yga2GkC-MHPPA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7 May 2016 at 16:21, Stephen Frost <sfrost(at)snowman(dot)net> wrote:

> * Simon Riggs (simon(at)2ndQuadrant(dot)com) wrote:
> > On 7 May 2016 at 16:14, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > > > If we don't lock it then we will have a inconsistent dump that will
> fail
> > > > later, if dumped while an object is being dropped.
> > > > Do we want an inconsistent dump?
> > >
> > > The dump won't be inconsistent, as Tom pointed out. The catalog tables
> > > are read using a repeatable read transaction, which will be consistent.
> >
> > The scan is consistent, yes, but the results would not be.
>
> I'm not following- the results are entirely dependent on the scan, so if
> the scan is consistent, how could the results not be?
>

Objects would no longer exist because of concurrent DROPs.

You agreed before, why did you change?

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-05-07 14:31:39 Re: pg_dump broken for non-super user
Previous Message Stephen Frost 2016-05-07 14:21:22 Re: pg_dump broken for non-super user