| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimising compactify_tuples() |
| Date: | 2020-09-16 18:54:24 |
| Message-ID: | CANP8+jK8LkN1PsY6+dHRYVdzRAW5i1C2Q_rBUHsyPD_v41HCcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 10 Sep 2020 at 14:45, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I've also attached another tiny patch that I think is pretty useful
> separate from this. It basically changes:
>
> LOG: redo done at 0/D518FFD0
>
> into:
>
> LOG: redo done at 0/D518FFD0 system usage: CPU: user: 58.93 s,
> system: 0.74 s, elapsed: 62.31 s
>
> (I was getting sick of having to calculate the time spent from the log
> timestamps.)
I really like this patch, thanks for proposing it.
Should pg_rusage_init(&ru0);
be at the start of the REDO loop, since you only use it if we take that path?
--
Simon Riggs http://www.2ndQuadrant.com/
Mission Critical Databases
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-09-16 19:21:45 | Re: Optimising compactify_tuples() |
| Previous Message | Tom Lane | 2020-09-16 18:44:39 | Re: recovering from "found xmin ... from before relfrozenxid ..." |