| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | Re: Yet another small patch - reorderbuffer.c:1099 |
| Date: | 2016-04-05 09:19:14 |
| Message-ID: | CANP8+jJWjt-RD8oA_ya=MXcs3OPmg4Qxt=JUy_1ovnBJ5Fi6=g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5 April 2016 at 10:12, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-04-05 12:07:40 +0300, Aleksander Alekseev wrote:
> > > I recall discussing this code with Andres, and I think that he has
> > > mentioned me this is intentional, because should things be changed for
> > > a reason or another in the future, we want to keep in mind that a list
> > > of TXIDs and a list of sub-TXIDs should be handled differently.
> >
> > I see. If this it true I think there should be a comment that explains
> > it. When you read such a code you suspect a bug. Not mentioning that
> > static code analyzers (I'm currently experimenting with Clang and PVS
> > Studio) complain about code like this.
>
> There's different comments in both branches...
Then one or both of the comments is incomplete.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-04-05 09:26:41 | Re: Support for N synchronous standby servers - take 2 |
| Previous Message | Simon Riggs | 2016-04-05 09:13:50 | Re: Support for N synchronous standby servers - take 2 |