Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders
Date: 2017-04-23 10:10:33
Message-ID: CANP8+jJ8_NMHQ69C1h0ouBtC4xCni=0X5-eQ6vEyWONyaLU59A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 22 April 2017 at 16:41, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> The assertion fails reliably for me, because standby2's reported write
>> LSN jumps backwards after the timeline changes: for example I see
>> 3020000 then 3028470 then 3020000 followed by a normal progression.
>> Surprisingly, 004_timeline_switch.pl reports success anyway. I'm not
>> sure why the test fails sometimes on tern, but you can see that even
>> when it passed on tern the assertion had failed.
>
> Whoa. This just turned into a much larger can of worms than I expected.
> How can it be that processes are getting assertion crashes and yet the
> test framework reports success anyway? That's impossibly
> broken/unacceptable.

Agreed, thanks for fixing.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-04-23 13:26:47 pgsql: Fix TAP infrastructure to support Mingw better
Previous Message Tom Lane 2017-04-23 06:01:34 Re: [COMMITTERS] pgsql: Replication lag tracking for walsenders

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-04-23 10:44:12 Re: Statistics "dependency"
Previous Message Simon Riggs 2017-04-23 10:05:44 Re: StandbyRecoverPreparedTransactions recovers subtrans links incorrectly