| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench MAX_ARGS |
| Date: | 2019-02-26 17:45:04 |
| Message-ID: | CANP8+j+qfcSGdKz4kZc5acf=nRp3PrixycD3LM1qFHDzuLsZ2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 26 Feb 2019 at 17:38, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2019-02-26 12:57:14 +0000, Simon Riggs wrote:
> > On Tue, 26 Feb 2019 at 12:19, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
> > I've put it as 256 args now.
> >
> > The overhead of that is about 2kB, so not really an issue.
>
> Why not just allocate it dynamically? Seems weird to have all these
> MAX_ARGS, MAX_SCRIPTS ... commands.
For me, its a few minutes work to correct a problem and report to the
community.
Dynamic allocation, run-time errors is all getting too time consuming for a
small thing.
> The eighties want their constants back ;)
>
Made me smile, thanks. ;-)
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-26 17:51:23 | Re: pgbench MAX_ARGS |
| Previous Message | Fujii Masao | 2019-02-26 17:42:32 | Re: Remove Deprecated Exclusive Backup Mode |