From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Greg Stark <stark(at)mit(dot)edu> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_sequence catalog |
Date: | 2016-09-05 14:13:15 |
Message-ID: | CANP8+j+f-kMQMVykNpbduP2Uh98KqZxjzSrTOQGtq=C+2DXsLg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 4 September 2016 at 23:17, Greg Stark <stark(at)mit(dot)edu> wrote:
> On Wed, Aug 31, 2016 at 3:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Uh, not as subtly as all that, because "select * from sequence" will
>> now return a different set of columns, which will flat out break a
>> lot of clients that use that method to get sequence properties.
>
> So? Clients expect changes like this between major releases surely.
> Subtle changes that cause silent breakage for end-users seems scarier
> than unsubtle breakage that tool authors can fix.
Agreed; some change in the behaviour if SELECT * FROM sequence is
effectively part of this proposal. I was going to make the same
comment myself.
I think we should balance the problems caused by not having a sequence
catalog against the problems caused by changing the currently somewhat
broken situation.
I vote in favour of applying Peter's idea/patch, though if that is not
acceptable I don't think its worth spending further time on for any of
us, so if thats the case lets Return with Feedback and move on.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Ildar Musin | 2016-09-05 14:21:50 | Re: Index Onlys Scan for expressions |
Previous Message | Vik Fearing | 2016-09-05 14:10:06 | Re: INSERT .. SET syntax |