| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump broken for non-super user |
| Date: | 2016-05-07 14:00:03 |
| Message-ID: | CANP8+j+CqU9vCqPV3m34oi8-C-0N4+PjfvkurAfpTo5sXZ4o8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4 May 2016 at 16:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Why is it that we need to lock a table at all if we're just going to dump
> its ACL?
We don't, but surely that's the wrong question.
If we don't lock it then we will have a inconsistent dump that will fail
later, if dumped while an object is being dropped.
Do we want an inconsistent dump?
For what reason are we changing existing behaviour? There is no bug here,
as Stephen explained.
So this is a behaviour change after freeze with uncertain purpose.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2016-05-07 14:08:48 | Re: Reviewing freeze map code |
| Previous Message | Stephen Frost | 2016-05-07 13:36:06 | Re: [COMMITTERS] pgsql: Add TAP tests for pg_dump |