Re: Don'st start streaming after creating a slot in pg_receivexlog

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Don'st start streaming after creating a slot in pg_receivexlog
Date: 2015-07-29 12:53:31
Message-ID: CANP8+j+3uYib0LoNeFTedUX1BrpnoyeOBxXo67=SFR-bKeQe-g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29 July 2015 at 12:51, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:

> In short, I would propose the following:
> - Have --create-slot only create a slot, then exit for both
> pg_recvlogical and pg_receivexlog.
> - Have --drop-slot drop a slot, then exit.
>

It makes more sense to create one new utility to issue replication commands
than to enhance multiple utility commands to have bizarre looking
additional features and modes.

pg_reputil --create-slot
pg_reputil --drop-slot
etc

though I prefer the idea of using psql and the already existing slot
functions than doing all of this extra code that needs maintaining.

- Remove the --start switch in pg_recvlogical, and let the utility
> start streaming by default.
> By doing so both utilities will behave similarly with the same set of
> options.
>

+1

That way all the utilities have just one thing they do.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-07-29 12:54:01 Re: pg_basebackup and replication slots
Previous Message Simon Riggs 2015-07-29 12:45:22 Re: pg_basebackup and replication slots