| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)berkus(dot)org> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal for changes to recovery.conf API |
| Date: | 2017-03-27 08:27:05 |
| Message-ID: | CANP8+j+0JhYs_oK4gGQh4-Ga2m1CmVEUf=4QTr4HUKt7pC8RJw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7 March 2017 at 23:31, Josh Berkus <josh(at)berkus(dot)org> wrote:
> On 03/02/2017 07:13 AM, David Steele wrote:
>> Hi Simon,
>>
>> On 2/25/17 2:43 PM, Simon Riggs wrote:
>>> On 25 February 2017 at 13:58, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>>>
>>>> - trigger_file is removed.
>>>> FWIW, my only complain is about the removal of trigger_file, this is
>>>> useful to detect a trigger file on a different partition that PGDATA!
>>>> Keeping it costs also nothing..
>>>
>>> Sorry, that is just an error of implementation, not intention. I had
>>> it on my list to keep, at your request.
>>>
>>> New version coming up.
>>
>> Do you have an idea when the new version will be available?
>
> Please? Having yet another PostgreSQL release go by without fixing
> recovery.conf would make me very sad.
I share your pain, but there are various things about this patch that
make me uncomfortable. I believe we are looking for an improved design
not just a different design.
I think the best time to commit such a patch is at the beginning of a
new cycle, so people have a chance to pick out pieces they don't like
and incrementally propose changes.
So I am going to mark this MovedToNextCF, barring objections from
committers willing to make it happen in this release.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aniruddha Deshpande | 2017-03-27 08:29:51 | Column widening without outage |
| Previous Message | Tsunakawa, Takayuki | 2017-03-27 08:26:52 | Re: Crash on promotion when recovery.conf is renamed |