Re: ecpg command does not warn COPY ... FROM STDIN;

From: Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Subject: Re: ecpg command does not warn COPY ... FROM STDIN;
Date: 2025-01-11 17:04:22
Message-ID: CANOn0Ez+gAOCcEVqaFGsjU4Ls3vKxe=ui-qxbq3iCf9baHsqTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Thu, Jan 9, 2025 at 9:27 PM Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com> wrote:
>
> > On 2025/01/09 20:34, Ryo Kanbayashi wrote:
> > > Dear Tom, Fujii-san, Kuroda-san,
> > >
> > > I saw comments of yours and recognized that better fix is below.
> > >
> > > - Fix of first attached patch which does not change warning message
> > >
> > > And I created patch entry of commitfest :)
> > > https://commitfest.postgresql.org/52/5497/
> > >
> > > What should I do additionally?
> > > Do I need to write patches for current supporting versions? (12.x - 17.x)
> >
> > Testing the patch across all supported versions would be helpful.
> > If adjustments are needed for specific versions, creating separate
> > patches for those would also be appreciated. Since v12 is no longer
> > supported, back-patching to it isn't necessary.
>
> thanks.
> I try these :)
>
> > BTW, regarding the discussion on the list, please avoid top-posting;
> > bottom-posting is the preferred style on this mailing list.
>
> I understand.
> I'll be careful from now on :)
>
> (Please Ignore: I attach renamed patch file for updating patch file on
> commitfest system)

I wrote a patch for release v13 - v17 additionally and tested it for
each release branch :)
As a result, two patch is needed for this fix.

copy_from_stdin_no_warning_for_master3.patch -> patch for master branch
copy_from_stdin_no_warning_for_stables.patch -> patch for v13 - v17

check_patches.sh -> utility script for testing above two patches on
each target branches
patch_checking_note_cf.txt -> checking result by check_patches.sh and etc
other files -> files which are needed for testing with check_patches.sh

[commitfest entry]
https://commitfest.postgresql.org/52/5497/

It would be helpful if someone could review patches I wrote :)

--
Best regards,
Ryo Kanbayashi
https://github.com/ryogrid

Attachment Content-Type Size
patch_checking_note_cf.txt text/plain 7.3 KB
copy_from_stdin_no_warning_for_master3.patch application/octet-stream 765 bytes
copy_from_stdin_no_warning_for_stables.patch application/octet-stream 767 bytes
check_patches.sh text/x-sh 5.2 KB
copy_from_should_be_warned.pgc application/octet-stream 576 bytes
copy_from_ok.pgc application/octet-stream 584 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-01-11 17:13:35 Re: NOT ENFORCED constraint feature
Previous Message Mahendra Singh Thalor 2025-01-11 16:08:12 Re: Non-text mode for pg_dumpall