Re: ecpg command does not warn COPY ... FROM STDIN;

Dear Tom, Fujii-san, Kuroda-san,

I saw comments of yours and recognized that better fix is below.

- Fix of first attached patch which does not change warning message

And I created patch entry of commitfest :)
https://commitfest.postgresql.org/52/5497/

What should I do additionally?
Do I need to write patches for current supporting versions? (12.x - 17.x)

--
Best regards,
Ryo Kanbayashi
https://github.com/ryogrid

On Thu, Jan 9, 2025 at 4:53 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Tom, Fujii-san,
>
> > > ISTM that ecpg supports COPY TO STDOUT and includes the regression test
> > "copystdout" for it. No?
> >
> > Oh right. (Pokes at it...) It looks like the backend accepts
> > "FROM STDOUT" as a synonym for "FROM STDIN", so that's why this
> > is checking for both spellings. But I agree it'd be better
> > for the error message to only use the standard spelling.
> >
> > Also I tried
> >
> > regression=# copy int4_tbl from program stdin;
> > ERROR: STDIN/STDOUT not allowed with PROGRAM
> >
> > So we probably don't need to bother with adjusting the check
> > to allow that.
>
> To confirm - I have no objections for the decision. I'm also think it is not
> an usual grammar. I checked the doc [1] and I could not find "COPY FROM STDOUT".
> I.e., first version is enough.
>
> [1]: https://www.postgresql.org/docs/devel/sql-copy.html
>
> Best regards,
> Hayato Kuroda
> FUJITSU LIMITED
>