From: | Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Srinu Perabattula <srinu(dot)perabattula(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Packagers: Handling upgrade checks |
Date: | 2019-02-05 12:27:08 |
Message-ID: | CANFyU96vaGUu7o4oZ-iP2aPzEFo-p5w0UhGvbigqtsfcY++HwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
On Wed, Jan 2, 2019 at 6:44 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Packagers,
>
> As you probably know, pgAdmin 4 checks for updates upon startup, and
> if a newer version is available, directs the user to www.pgadmin.org
> to download it.
>
> The is a problem if your pgAdmin came with a PostgreSQL installer (as
> you can't download them from our website), and potentially mildly
> annoying if you're a .deb or .rpm user.
>
> There are a couple of ways to optimise the experience for users here
> (one of which I just committed). I'll leave it up to each of you to
> choose what you want to do (Sandeep, I would suggest that the EDB
> installers use method 2).
>
> Method 1: Simply disable the upgrade check, and leave that to the
> operating systems update tools. To do this, create (or edit) a
> config_distro.py file that is installed alongside the config.py file
> from the pgAdmin source and include the line;
>
> UPGRADE_CHECK_ENABLED = False
>
> Method 2: For well known and trusted distributions we can support a
> custom check for your distribution. This involves 2 parts:
>
> 1) Let me know that you want a custom check, and I'll setup access for
> you to manage the version data on the pgAdmin website. We'll agree on
> a custom key for that data within the JSON file the website hosts.
>
> We want that for PG and EPAS installers. Will you please share the custom
key?
> 2) Create (or edit) a config_distro.py file that is installed
> alongside the config.py file from the pgAdmin source and include the
> line;
>
> UPGRADE_CHECK_KEY = '<your key>'
>
> With this method, a different section of the JSON datafile will be
> checked by your distribution of pgAdmin, thus allowing you to control
> both when it tells users a new version is available, and the URL to
> which they are directed.
>
> Makes sense. Will include this change in the upcoming PG and EPAS updates
that bundle pgAdmin.
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Sandeep Thakkar
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2019-02-05 13:36:39 | Re: Packagers: Handling upgrade checks |
Previous Message | Aditya Toshniwal | 2019-02-05 11:57:58 | Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases |