Re: Compilation of timezone source with zic fails (on mountpoint)

On Fri, Nov 4, 2016 at 8:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Sandeep Thakkar <sandeep(dot)thakkar(at)enterprisedb(dot)com> writes:
> > Anyway, I observed that there is change in the itsdir() function that it
> > now returns '2' for the symbolic links. Hence the error. Till previous
> > release, it used to return '0' for symbolic links. If hard links cannot
> be
> > used and it fallsback to symbolic links, then itsdir() should return '0'
> > for symbolic links. Isn't it?
>
> After some back-and-forth with the IANA crew, I've pushed a patch that
> I believe will fix this, but if you could try it in your environment that
> would make me feel better. Please check not only that the symlinks get
> made, but that they point somewhere sane, because that aspect of it
> seems to have been broken too :-(.
>
> I pushed the fix to HEAD only for the moment, but if you prefer testing on
> a back branch, the patch should apply fine there.
>
> With the patch, the build on 9.2 is now successful. Thanks! The patch
needs little change on 9.3 and 9.2. I have attached the patch for those 2
branches.
I used the -samefile option of find command to check that hard links (on
the other branches where we didn't see this issue) and symlinks (on 9.2)
match. I didn't see anything broken for symlinks.

> BTW, it would be a really good idea if you guys were running a buildfarm
> member that represented this build environment accurately, because it's
> clear that no one else, anywhere, is testing either PG or the upstream
> tzcode releases in such an environment.
>
> OK. Well, it's the 9.3/9.2 that we build on such an environment and except
this build error, we never observed any challenges since the first 9.2
release. Moreover, we also have another backup build farm where build setup
is different.

> regards, tom lane
>

--
Sandeep Thakkar