Re: [EXTERNAL] Re: Windows Application Issues | PostgreSQL | REF # 48475607

On Thu, Sep 5, 2024 at 5:46 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:

> On Thu, Sep 5, 2024 at 12:07 PM Haifang Wang (Centific Technologies
> Inc) <v-haiwang(at)microsoft(dot)com> wrote:
> > Good to know that, Thomas. I'm asking our tester to try it. Will let you
> know.
>
> To give a more serious response, I don't really expect anything
> "simple" about this patch not to work on Windows, as I know that it it
> rejects non-ASCII names as I showed (on all OSes), and I know that
> compiles and passes our tests on all our 4 CI operating systems:
>
> https://cirrus-ci.com/build/4941642090676224
>
> Really what I'm looking for is (1) feedback on the approach, code and
> comments, and thoughts about more complex scenarios I may have failed
> to think about, including say, pg_dump, pg_upgrade etc operational
> issues, which probably involves lots of previous experience with
> PostgreSQL, (2) opinions on whether we should add a test for these
> cases and how to put the UTF-8 into a script (I'm confused about the
> encoding of command line arguments), and (3) a nod from the EDB people
> involved in distributing this software on Windows.
>

We can help with producing the builds with the patches provided. You had
also
mentioned about the changes required in the installer script, will it still
be required?

--
Sandeep Thakkar