Re: Patch for pgAdmin4 RPM package

Thanks Dave.

On Fri, Jun 3, 2016 at 2:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
> <sandeep(dot)thakkar(at)enterprisedb(dot)com> wrote:
> > Hi Devrim, Hi Dave,
> >
> > I have updated the patch. The earlier patch may fail because of app
> bundle
> > commit in git.
> >
> > For testing, you may define the source tarball location as :
> > Source0:
> >
> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
> >
> > Known issue that I'm still working on:
> > 1. web rpm has a dependency on doc. But, even if I install doc, the web
> > still complains. Here is the scenario:
> > [root(at)localhost tmp]# rpm -ivh
> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> > error: Failed dependencies:
> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch
> > ... ( trimmed the python dependencies list here...)
> >
> > [root(at)localhost tmp]# rpm -ivh
> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> > Preparing... #################################
> > [100%]
> > Updating / installing...
> > 1:pgadmin4-docs-1.0_dev-1.rhel7 #################################
> > [100%]
> >
> >
> > [root(at)localhost tmp]# yum list | grep pgadmin4-docs
> > pgadmin4-docs.noarch 1.0_dev-1.rhel7
> > installed
> >
> >
> > [root(at)localhost tmp]# rpm -ivh
> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> > error: Failed dependencies:
> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch
>
> You have a typo - the Requires line is for pgadmin4-doc, but the RPM
> is pgadmin4-docs.
>
> Oh, right.

> Other review comments:
>
> - We have multiple identical pgadmin4.spec.in's in the patch. We need
> to get that down to a single file.
>
> - In fact, why do we need a directory for each distro at all? As far
> as I can see, the only difference is the $DIST definition, which is
> surely something we can get programmatically very easily. It seems to
> me we could reduce this all to 3 files - Makefile, README and
> pgadmin4.spec.in
>
> Agree. I copied the structure from somewhere thinking this is good to have
more OS specific changes.

> - make rpm has a dependency on make prep. This has 2 issues as far as I
> can see:
>
> - It does a git pull, which is bad. If I'm making an RPM from within
> the source tree, I want it for the current source. The git pull only
> makes sense for external builds, i.e. in a much larger automated build
> system.
>
> - It goes and grabs the source code and patches from the FTP site.
> Again, this is not what I want for an "in-tree" build. I want to use
> the source code as I have it now.
>
> Okay. got it. Will remove downloading the tarballs and build the cloned
source.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Sandeep Thakkar