Re: [Proposal] Global temporary tables

From: Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>
To: 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, 蔡松露(子嘉) <zijia(at)taobao(dot)com>, "Cai, Le" <le(dot)cai(at)alibaba-inc(dot)com>
Subject: Re: [Proposal] Global temporary tables
Date: 2020-06-09 12:15:34
Message-ID: CANEvxPp-7yEBxD=N+HnRhPP+8wKUYmXgvQPxf445hphyQaH8ww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 29, 2020 at 8:52 AM 曾文旌 <wenjing(dot)zwj(at)alibaba-inc(dot)com> wrote:

> 2020年4月27日 下午9:48,Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com> 写道:
>
> Thanks Wenjing, for the fix patch for previous issues.
> I have verified the issues, now those fix look good to me.
> But the below error message is confusing(for gtt2).
>
> postgres=# drop table gtt1;
> ERROR: cannot drop global temp table gtt1 when other backend attached it.
>
> postgres=# drop table gtt2;
> ERROR: cannot drop index idx2 on global temp table gtt2 when other
> backend attached it.
>
> I feel the above error message shown for "DROP TABLE gtt2;" is a bit
> confusing(looks similar to DROP INDEX gtt2;).
> If possible, can we keep the error message simple as "ERROR: cannot drop
> global temp table gtt2 when other backend attached it."?
> I mean, without giving extra information for the index attached to that
> GTT.
>
> Fixed the error message to make the expression more accurate. In v33.
>

Thanks Wenjing. We verified your latest patch(gtt_v33) focusing on all
reported issues and they work fine.
Thanks.
--

With Regards,
Prabhat Kumar Sahu
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Georgios 2020-06-09 12:19:31 Re: Include access method in listTables output
Previous Message Joel Mariadasan (jomariad) 2020-06-09 11:58:33 Postgres installer with pgAdmin 4.22