Add PG CI to older PG releases

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Add PG CI to older PG releases
Date: 2023-08-10 14:43:24
Message-ID: CAN55FZ3m0Cyq8TS1Ai0Me2jmabBNZrZVrTYO2UJbeeJVFwA7Qg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

PG CI is added starting from PG 15, adding PG CI to PG 14 and below
could be beneficial. So, firstly I tried adding it to the
REL_14_STABLE branch. If that makes sense, I will try to add PG CI to
other old PG releases.

'Add PG CI to PG 14' patch is attached. I merged both CI commits and
the least amount of commits to pass the CI on all OSes.

Addition to CI commits, other changes are:

1_ 76e38b37a5f179d4c9d2865ff31b79130407530b is added for debugging
Windows. Also a couple of SSL tests were failing without this because
the log file is empty. Example failures on 001_ssltests.pl:

# Failed test 'certificate authorization succeeds with DN mapping:
log matches'
# at c:/cirrus/src/test/perl/PostgresNode.pm line 2195.
# ''
# doesn't match '(?^:connection authenticated:
identity="CN=ssltestuser-dn,OU=Testing,OU=Engineering,O=PGDG"
method=cert)'

# Failed test 'certificate authorization succeeds with CN mapping:
log matches'
# at c:/cirrus/src/test/perl/PostgresNode.pm line 2195.
# ''
# doesn't match '(?^:connection authenticated:
identity="CN=ssltestuser-dn,OU=Testing,OU=Engineering,O=PGDG"
method=cert)'

# Failed test 'certificate authorization fails with client cert
belonging to another user: log matches'
# at c:/cirrus/src/test/perl/PostgresNode.pm line 2243.
# ''
# doesn't match '(?^:connection authenticated:
identity="CN=ssltestuser" method=cert)'
# Looks like you failed 3 tests of 110.

2_ 45f52709d86ceaaf282a440f6311c51fc526340b is added for fixing socket
directories on Windows.

3_ I removed '--with-zstd' since it was not supported yet.

Any kind of feedback would be appreciated.

Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v1-0001-ci-Add-PG-CI-to-PG-14.patch text/x-diff 31.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonah H. Harris 2023-08-10 14:47:31 Re: libpq compression (part 2)
Previous Message Jelte Fennema 2023-08-10 14:31:27 Re: proposal: psql: show current user in prompt