Re: plperl version on the meson setup summary screen

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Zharkov Roman <r(dot)zharkov(at)postgrespro(dot)ru>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: plperl version on the meson setup summary screen
Date: 2024-11-29 08:26:00
Message-ID: CAN55FZ3_fZH=JSn=q+a+hqJKAHh_i1NNaAcpyiy6MqTkh5AuoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 29 Nov 2024 at 08:40, Zharkov Roman <r(dot)zharkov(at)postgrespro(dot)ru> wrote:
>
> Hello,
>
> On 2024-11-27 21:50, Andrew Dunstan wrote:
> > it should give the same answer
>
> Sometimes "version" and "api_versionstring" are different. Here are two
> simple examples from my windows system and from a linux system of one of
> my colleagues:
>
> C:\Temp>perl -MConfig -e "print \"$Config{api_versionstring}\n\"; print
> \"$Config{version}\n\""
> 5.32.0
> 5.32.1
> C:\Temp>perl -v
> This is perl 5, version 32, subversion 1 (v5.32.1) built for
> MSWin32-x64-multi-thread
>
> perl -MConfig -e 'print "$Config{api_versionstring}\n"; print
> "$Config{version}\n"'
> 5.38.0
> 5.38.2
> perl -v
> This is perl 5, version 38, subversion 2 (v5.38.2)

It is different for me too:

$ perl -MConfig -e 'print "$Config{api_versionstring}\n";
print"$Config{version}\n"'
5.38.0
5.38.2
$ perl -v
This is perl 5, version 38, subversion 2 (v5.38.2)

On Wed, 27 Nov 2024 at 17:51, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 2024-10-17 Th 10:02 PM, Zharkov Roman wrote:
> > With the attached patch we can see the "perlversion" in the summary
> > information table. But without a beautiful console colorize.
> >
> Yeah, the lack of version number has mildly annoyed me too, so let's fix
> it. I haven't found the right secret sauce to make the version number
> appear colorized, either. Maybe some meson guru can tell us how.

It seems that we can force ANSI colors:

- 'plperl': [perl_dep, perlversion],
+ 'plperl': [perl_dep, '\033[1;36m(at)0@\033[0m'.format(perlversion)],

But I think this is too hacky. I am not sure if that is the best way
or worth it.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2024-11-29 08:37:20 Re: [PATCH] SVE popcount support
Previous Message Zhijie Hou (Fujitsu) 2024-11-29 08:19:33 RE: crash with synchronized_standby_slots