Re: PG_TEST_EXTRA and meson

Hi,

On Wed, 17 Jul 2024 at 13:23, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Wed, 17 Jul 2024 at 13:13, Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > xid_wraparound tests are run if PG_TEST_EXTRA contains xid_wraparound
> > or it is not set. Any other setting will not run xid_wraparound test.
> > That's how the patch is coded but it isn't intuitive that changing
> > whether a test is run by default would require configuring the build
> > again. Probably we should just get rid of config time PG_TEST_EXTRA
> > altogether.
> >
> > I am including +Tristan Partin who knows meson better.
> >
> > If you are willing to work on this further, please add it to the commitfest.
>
> I think I know why there is confusion. Could you try to set
> PG_TEST_EXTRA with quotes? Like PG_TEST_EXTRA="ldap mts
> xid_wraparound".

Sorry, the previous reply was wrong; I misunderstood what you said.
Yes, that is how the patch was coded and I agree that getting rid of
config time PG_TEST_EXTRA could be a better alternative.

--
Regards,
Nazir Bilal Yavuz
Microsoft