Re: allow meson to find ICU in non-standard localtion

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: allow meson to find ICU in non-standard localtion
Date: 2023-02-24 10:43:26
Message-ID: CAN55FZ2USGwzbcfFcio2pnq8dhKxRd2R_+xN+nv-Umt5SUFUUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thanks for the patch.

On Wed, 22 Feb 2023 at 21:26, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> I'm not sure it's the right thing to do though. One downside is that it
> doesn't output the version that it finds, it only outputs "YES".

- icu = dependency('icu-uc', required: icuopt.enabled())
- icu_i18n = dependency('icu-i18n', required: icuopt.enabled())

I think you can do dependency checks with 'required: false' first and
if they weren't found by dependency checks; then you can do
cc.find_library() checks. This also solves only the outputting "YES"
problem if they were found by dependency checks.

Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-02-24 11:26:42 Re: dynamic result sets support in extended query protocol
Previous Message Tomas Vondra 2023-02-24 10:25:55 Re: PATCH: Using BRIN indexes for sorted output