Re: ci: Allow running mingw tests by default via environment variable

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Wolfgang Walther <walther(at)technowledgy(dot)de>
Subject: Re: ci: Allow running mingw tests by default via environment variable
Date: 2025-04-07 13:03:48
Message-ID: CAN55FZ0x55wCTjnPeaNoRr14QkamVfY9UPSdatXqow529ziW5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, 5 Mar 2025 at 18:51, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> I'm inclined to think we should apply to this to all branches with CI support,
> not just master. It's kind of annoying to have CI infrastructure changes like
> this that differ between branches. Thoughts?

I am sharing patches per branch until we come up with a better
solution. Some remarks:

REL_15: It doesn't have any manual tasks, so per repository trigger
patch (Thomas' patch) is omitted.
REL_16: Only Mingw task is manual.
REL_17: Only Mingw task is manual.

While rebasing them, I realized that we use
'REPO_CI_AUTOMATIC_TRIGGER_TASKS' for all branches. So, we don't have
per branch 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' configuration option. Is
that a problem?

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
REL_15_v5-0001-ci-Simplify-ci-os-only-handling.patch text/x-patch 5.5 KB
REL_16_v5-0001-ci-Per-repo-triggers-for-not-automated-tasks.patch text/x-patch 6.3 KB
REL_16_v5-0002-ci-Simplify-ci-os-only-handling.patch text/x-patch 5.0 KB
REL_17_v5-0001-ci-Per-repo-triggers-for-not-automated-tasks.patch text/x-patch 6.3 KB
REL_17_v5-0002-ci-Simplify-ci-os-only-handling.patch text/x-patch 5.0 KB
Upstream_v5-0001-ci-Per-repo-triggers-for-not-automated-tasks.patch text/x-patch 7.2 KB
Upstream_v5-0002-ci-Simplify-ci-os-only-handling.patch text/x-patch 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-04-07 13:08:49 Re: pgsql: Convert 'x IN (VALUES ...)' to 'x = ANY ...' then appropriate
Previous Message Andrei Lepikhov 2025-04-07 12:54:24 Re: An incorrect check in get_memoize_path