From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
---|---|
To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: PG_TEST_EXTRA and meson |
Date: | 2024-07-16 22:01:10 |
Message-ID: | CAN55FZ0XP7pX9zW_SjqH_Ce4va6bNe1MWt9GAp7acfXtNrbR2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Wed, 17 Jul 2024 at 00:27, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Tue, Jul 16, 2024 at 2:12 PM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> >
> > 2- If PG_TEST_EXTRA is set from the setup command, use it from the
> > setup command and discard the environment variable. If PG_TEST_EXTRA
> > is not set from the setup command, then use it from the environment.
>
> Is there a way for the environment to override the Meson setting
> rather than vice-versa? My vote would be to have both available, but
> with the implementation in patch 2 I'd still have to reconfigure if I
> wanted to change my test setup.
I think something like attached does the trick. I did not test it
extensively but it passed the couple of tests I tried.
--
Regards,
Nazir Bilal Yavuz
Microsoft
Attachment | Content-Type | Size |
---|---|---|
Solution-3.patch | text/x-patch | 3.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2024-07-16 22:14:36 | Re: RFC: pg_stat_logmsg |
Previous Message | Nathan Bossart | 2024-07-16 21:38:06 | Re: [PATCH] Refactor pqformat.{c,h} and protocol.h |