| From: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Hannu Krosing <hannuk(at)google(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: .ready and .done files considered harmful |
| Date: | 2021-09-08 17:45:24 |
| Message-ID: | CAN1g5_Fv8Dk5fUYT9JNLZVi7_ObKEUugGS8SUEu3Bs+BJHWQyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > I guess we still have to pick one or the other, but I don't really
> > know how to do that, since both methods seem to be relatively fine,
> > and the scenarios where one is better than the other all feel a little
> > bit contrived. I guess if no clear consensus emerges in the next week
> > or so, I'll just pick one and commit it. Not quite sure yet how I'll
> > do the picking, but we seem to all agree that something is better than
> > nothing, so hopefully nobody will be too sad if I make an arbitrary
> > decision. And if some clear agreement emerges before then, even
> > better.
>
> I will be happy to see this fixed either way.
+1
> > I agree, but it should probably be something like DEBUG3 instead of
> > LOG.
>
> I will update it in the next patch.
Updated log level to DEBUG3 and rebased the patch. PFA patch.
Thanks,
Dipesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-keep-trying-the-next-file-approach.patch | text/x-patch | 12.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-09-08 17:46:14 | Re: The Free Space Map: Problems and Opportunities |
| Previous Message | Tom Lane | 2021-09-08 17:25:08 | Re: [PATCH] Add tab-complete for backslash commands |