| From: | Krasiyan Andreev <krasiyan(at)gmail(dot)com> |
|---|---|
| To: | Oliver Ford <ojford(at)gmail(dot)com> |
| Cc: | Tatsuo Ishii <ishii(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vik Fearing <vik(at)postgresfriends(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, andrew(at)tao11(dot)riddles(dot)org(dot)uk, David Fetter <david(at)fetter(dot)org> |
| Subject: | Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options |
| Date: | 2025-03-29 07:51:55 |
| Message-ID: | CAN1PwomkQhCb50oF8cUJUkjgdwCjPKXLW10_DdoPR_baPxLi=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Patch applies and compiles, all included tests passed and after the latest
fixes for non-nulls array, performance is near to lead/lag without support
of "ignore nulls".
I have been using the last version for more than one month in a production
environment with real data and didn't find any bugs, so It is ready for
committer status.
На чт, 13.03.2025 г. в 9:49 Oliver Ford <ojford(at)gmail(dot)com> написа:
>
>
> On Sun, 9 Mar 2025, 20:07 Oliver Ford, <ojford(at)gmail(dot)com> wrote:
>
>> On Sun, Mar 9, 2025 at 6:40 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>>
>>> > Attached version removes the non-nulls array. That seems to speed
>>> > everything up. Running the above query with 1 million rows averages
>>> 450ms,
>>> > similar when using lead/lag.
>>>
>>> Great. However, CFbot complains about the patch:
>>>
>>> https://cirrus-ci.com/task/6364194477441024
>>>
>>>
>> Attached fixes the headerscheck locally.
>>
>
> v11 attached because the previous version was broken by commit 8b1b342
>
>>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-03-29 08:12:24 | Re: support ALTER TABLE DROP EXPRESSION for virtual generated column |
| Previous Message | Julien Tachoires | 2025-03-29 07:46:01 | Re: Allow table AMs to define their own reloptions |